This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Update Pallet Bags List to use ListError
#11342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
reviewed
May 3, 2022
frame/bags-list/src/lib.rs
Outdated
| Self::deposit_event(Event::<T, I>::Rebagged { who: account.clone(), from, to }); | ||
| }; | ||
| maybe_movement | ||
| Self::deposit_event(Event::<T, I>::ScoreUpdated { who: account.clone(), new_score }); |
Contributor
There was a problem hiding this comment.
to be clear, this event is currently non-existent, because we don't have the notion of a "stored score" yet. That should come in your next PR.
Member
Author
There was a problem hiding this comment.
Probably this event is being emitted in the wrong place then...
kianenigma
approved these changes
May 3, 2022
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
I think it might be better to bring all bags-list changes alltogether in this PR, since some things don't make sense alone. Nonetheless look good in its current shape as well.
Member
Author
Besides the event above (which I removed), what else? |
shawntabrizi
added
B0-silent
KiChjang
reviewed
May 3, 2022
KiChjang
reviewed
May 3, 2022
KiChjang
reviewed
May 3, 2022
KiChjang
approved these changes
May 3, 2022
Contributor
KiChjang
left a comment
KiChjang
left a comment
There was a problem hiding this comment.
Can merge after fixing some small nits.
Co-authored-by: Keith Yeung <[email protected]>
Member
Author
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for a7e5623 |
Member
Author
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/polkadot#5443 |
godcodehunter
pushed a commit
to sensoriumxr/substrate
that referenced
this pull request
Jun 22, 2022
* extract list error changes from kiz-revamp-sorted-list-providers-2-approval-stake * some fixes * weight -> score * Update tests.rs * Update tests.rs * more fixes * remove score updated event * Update frame/bags-list/src/lib.rs Co-authored-by: Keith Yeung <[email protected]> Co-authored-by: Keith Yeung <[email protected]>
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* extract list error changes from kiz-revamp-sorted-list-providers-2-approval-stake * some fixes * weight -> score * Update tests.rs * Update tests.rs * more fixes * remove score updated event * Update frame/bags-list/src/lib.rs Co-authored-by: Keith Yeung <[email protected]> Co-authored-by: Keith Yeung <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* extract list error changes from kiz-revamp-sorted-list-providers-2-approval-stake * some fixes * weight -> score * Update tests.rs * Update tests.rs * more fixes * remove score updated event * Update frame/bags-list/src/lib.rs Co-authored-by: Keith Yeung <[email protected]> Co-authored-by: Keith Yeung <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting a consolidated piece of: https://github.com/paritytech/substrate/pull/11013/files#
polkadot companion: paritytech/polkadot#5443